Changeset 4854 for vlo/branches/vlo-3.0/vlo-web-app/src

Timestamp:

03/31/14 15:12:25 (11 years ago)

Author:

Twan Goosen

Message:

wrote tests for DocumentFieldsProvider?

Location:

vlo/branches/vlo-3.0/vlo-web-app/src

Files:

• main/java/eu/clarin/cmdi/vlo/wicket/provider/DocumentFieldsProvider.java (modified) (4 diffs)
• test/java/eu/clarin/cmdi/vlo/wicket/provider (added)
• test/java/eu/clarin/cmdi/vlo/wicket/provider/DocumentFieldsProviderTest.java (added)

vlo/branches/vlo-3.0/vlo-web-app/src/main/java/eu/clarin/cmdi/vlo/wicket/provider/DocumentFieldsProvider.java

@@ -23 +23 @@
 import java.util.Collection;
 import java.util.Iterator;
+import java.util.List;
 import org.apache.solr.common.SolrDocument;
 import org.apache.wicket.markup.repeater.data.IDataProvider;
@@ -37 +38 @@
     private final IModel<SolrDocument> documentModel;
     private final FieldFilter fieldFilter;
-    private Collection<DocumentFieldModel> fields;
+    private List<DocumentFieldModel> fields;
 
     /**
@@ -49 +50 @@
     }
 
-    private Collection<DocumentFieldModel> getFields() {
+    private List<DocumentFieldModel> getFields() {
         if (fields == null) {
             // lazy loading/caching of included field models
@@ -63 +64 @@
     }
 
+    /**
+     *
+     * @param first index of the first item in the list returned by the iterator
+     * @param count is ignored
+     * @return
+     */
     @Override
     public Iterator<? extends DocumentField> iterator(long first, long count) {
-        return getFields().iterator();
+        return getFields().listIterator((int) first);
     }