Changeset 5938 for ComponentRegistry/trunk/ComponentRegistry/src

Timestamp:

01/21/15 16:09:31 (10 years ago)

Author:

Twan Goosen

Message:

Feedback improvement: the appropriate error is now sent to the user when they try to publish a component that uses (group) private components - rather than a 500 server error
Refs #720

Location:

ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/rest

Files:

• ComponentRegistryRestService.java (modified) (1 diff)
• MDValidator.java (modified) (2 diffs)

ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/rest/ComponentRegistryRestService.java

@@ -691 +691 @@
             Principal principal = checkAndGetUserPrincipal();
             ComponentRegistry registry = this.getBaseRegistry();
+            registry.setRegistrySpace(RegistrySpace.PUBLISHED);
             ProfileDescription desc = registry.getProfileDescriptionAccessControlled(profileId);
             if (desc != null) {

ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/rest/MDValidator.java

@@ -170 +170 @@
                 };
                 // a private component for a private registry is available only if its owner is the owner of the resgitry
-                if (registry.getRegistrySpace().equals(RegistrySpace.PRIVATE)) {
+                if (RegistrySpace.PRIVATE.equals(registry.getRegistrySpace())) {
                     if(registry.canCurrentUserAccessDescription(componentId)) {
                         return;
@@ -178 +178 @@
 
                 } else { // a private component in a group registry is availabe only if it belongs to the group
-                    if (registry.getRegistrySpace().equals(RegistrySpace.GROUP)) {
+                    if (RegistrySpace.GROUP.equals(registry.getRegistrySpace())) {
                         if (registry.getGroupId() == null) {
                             errorMessages.add(COMPONENT_REGISTRY_EXCEPTION_ERROR + "in the group space, the group id is null");