Changeset 2756

Timestamp:

03/27/13 15:32:08 (11 years ago)

Author:

twagoo

Message:

Close log file after reading tail
[Refs #294]

File:

• ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/frontend/ViewLogPage.java (modified) (1 diff)

ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/frontend/ViewLogPage.java

@@ -47 +47 @@
             try {
                 final RandomAccessFile raLogFile = geFileTail(logFile, tailSize);
-                final String content = getLogFileContent(raLogFile);
+                try {
+                    final String content = getLogFileContent(raLogFile);
 
-                add(new Label("logLabel", String.format("Showing final %s bytes (or less) of total %s in %s:", numberFormat.format(tailSize), numberFormat.format(raLogFile.length()), logFile)));
-                add(new TextArea("logText", new Model(content)));
+                    add(new Label("logLabel", String.format("Showing final %s bytes (or less) of total %s in %s:", numberFormat.format(tailSize), numberFormat.format(raLogFile.length()), logFile)));
+                    add(new TextArea("logText", new Model(content)));
 
-                add(new DownloadLink("logDownloadLink", logFile));
+                    add(new DownloadLink("logDownloadLink", logFile));
+                } finally {
+                    raLogFile.close();
+                }
             } catch (IOException ioEx) {
                 add(new Label("logLabel", "Could not read from log file. See error message below."));