Changeset 4055

Timestamp:

11/19/13 13:53:31 (10 years ago)

Author:

sanmai

Message:

• Fix port number parameter to httplib.HTTPConnection, to convert it to integer and

raise an error if that failed. It seems that when a string is passed for the 'port'
argument, no exception is raised by httplib, but irregular things happen such as
fictitious HTTP response codes being returned.

File:

• monitoring/plugins/mpi/generic_tla_monitoring.py (modified) (3 diffs)

monitoring/plugins/mpi/generic_tla_monitoring.py

@@ -274 +274 @@
     #if authorize is None : authorize = True
 
+    try:
+        port_number = int(port_number)
+    except ValueError : 
+        return { "code"      : "CRITICAL", 
+         "message"   : 'The port number specified, "{0}", cannot be converted to an integer.'.format(port_number)
+       }
+
     def handle_connection_failure(problem_description) :
         err_log_file_path = os.path.normpath("/tmp/" + special_plugin_file_name + "_err_connection_failure__" + http_path.replace('/' , '%2F') + "__" + timestamp + ".log")
@@ -288 +295 @@
     
     try :
+        pdb.set_trace()
         conn = httplib.HTTPConnection(host = host, 
                                       port = port_number, 
@@ -350 +358 @@
                     return {
                               "code"      : "CRITICAL", 
-                              "message"   : 'Host %s is up but the response to GET "%s" implies an infinite redirection (to "%s").' % (host, http_path)
+                              "message"   : 'Host %s is up but the response to GET "%s" implies an infinite redirection (to "%s").' % (host, http_path, http_path)
                             }