Changeset 4234

Timestamp:

01/09/14 15:03:36 (10 years ago)

Author:

twagoo

Message:

Refactored adding theme as session page parameter
Merging with session parameters in FacetLinkPanel? and in ShowResultPage?

Location:

vlo/branches/to-wicket-1.6/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo

Files:

• VloSession.java (modified) (8 diffs)
• VloWebApplication.java (modified) (2 diffs)
• pages/FacetLinkPanel.java (modified) (2 diffs)
• pages/ShowResultPage.java (modified) (4 diffs)

vlo/branches/to-wicket-1.6/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/VloSession.java

@@ -1 @@
-
 package eu.clarin.cmdi.vlo;
 
@@ -7 +6 @@
 
 /**
- * A web session containing a VLO theme and parameters that are considered to
- * be persistent in a VLO session.
- * 
+ * A web session containing a VLO theme and parameters that are considered to be
+ * persistent in a VLO session.
+ *
  * Note that these parameters can include the specification of the theme.
- * 
+ *
  * @author keeloo
  */
@@ -17 +16 @@
 
     // remember the parameters that need to persist in URLs to VLO pages in this session
-    public PageParameters vloSessionPageParameters = new PageParameters();
+    private PageParameters vloSessionPageParameters = new PageParameters();
 
     // remember this session's theme
@@ -24 +23 @@
     /**
      * Construct a session object with a request parameter
-     * 
-     * @param request 
+     *
+     * @param request
      */
     public VloSession(Request request) {
@@ -34 +33 @@
     /**
      * Get the session's theme
-     * 
-     * @return the session's theme 
+     *
+     * @return the session's theme
      */
     public Theme getCurrentTheme() {
@@ -43 +42 @@
     /**
      * Set the session's theme
-     * 
+     *
      * @param theme the session's theme
      */
@@ -49 +48 @@
         this.currentTheme = theme;
     }
-    
+
     /**
      * Return the session's persistent parameters
-     * 
+     *
      * @return session parameters
      */
@@ -61 +60 @@
     /**
      * Add parameters to the session's persistent parameters
-     * 
+     *
      * @param parameters a page parameter map
      *
      */
     public void addVloSessionPageParameters(PageParameters parameters) {
-        
+
         vloSessionPageParameters.mergeWith(parameters);
     }

vlo/branches/to-wicket-1.6/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/VloWebApplication.java

@@ -18 +18 @@
 import org.apache.wicket.request.cycle.AbstractRequestCycleListener;
 import org.apache.wicket.request.cycle.RequestCycle;
+import org.apache.wicket.request.mapper.parameter.PageParameters;
 import org.apache.wicket.util.string.StringValue;
 
@@ -63 +64 @@
                     ((VloSession) Session.get()).setCurrentTheme(new Theme(object.toString()));
                     // remember the theme as a vlo session page parameter
-                    ((VloSession) Session.get()).vloSessionPageParameters.add("theme", object);
+                    PageParameters params = new PageParameters();
+                    params.add("theme", object);
+                    ((VloSession) Session.get()).addVloSessionPageParameters(params);
                 }
             }

vlo/branches/to-wicket-1.6/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/pages/FacetLinkPanel.java

@@ -1 +1 @@
 package eu.clarin.cmdi.vlo.pages;
 
+import eu.clarin.cmdi.vlo.VloSession;
 import org.apache.solr.client.solrj.response.FacetField.Count;
 import org.apache.wicket.markup.html.basic.Label;
@@ -19 +20 @@
         q.setFilterQuery(count);
         PageParameters param = q.getPageParameters();
+        param.mergeWith(((VloSession) VloSession.get()).getVloSessionPageParameters());
         
         Link<Count> facetLink = new BookmarkablePageLink("facetLink", FacetedSearchPage.class, param);

vlo/branches/to-wicket-1.6/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/pages/ShowResultPage.java

@@ -74 +74 @@
     public ShowResultPage(final PageParameters currentParam) {
         super(currentParam);
-        //TODO: Is encoding/decoding of the page parameter required (or can it be automated?)
+        //Document ID is assumed to have been encoded (typcially in DocumentLinkPanel) decode here
         final String docId = UrlDecoder.QUERY_INSTANCE.decode(
                 getPageParameters().get(PARAM_DOC_ID).toString(),
@@ -83 +83 @@
 
             // create parameters from the query, and add them with session related parameters
-            PageParameters newParam;
-            newParam = new PageParameters(query.getPageParameters());
+            PageParameters newParam = new PageParameters(query.getPageParameters());
             // add the session persistent parameters
-            newParam.mergeWith(((VloSession)this.getSession()).getVloSessionPageParameters());
+            newParam.mergeWith(((VloSession) this.getSession()).getVloSessionPageParameters());
 
             BookmarkablePageLink<String> backLink = new BookmarkablePageLink<String>("backLink", FacetedSearchPage.class, newParam);
@@ -429 +428 @@
         PageParameters newParam = new PageParameters(parameters);
         // add the session persistent paremeters
-        newParam.mergeWith(((VloSession)this.getSession()).getVloSessionPageParameters());
+        newParam.mergeWith(((VloSession) this.getSession()).getVloSessionPageParameters());
 
         final RequestCycle reqCycle = getRequestCycle();
@@ -460 +459 @@
         PageParameters newParam;
         newParam = new PageParameters(query.getPageParameters());
-        // add the session persistent parameters
-        // newParam.add(((VloSession)this.getSession()).getVloSessionPageParameters());
         newParam.add(ShowResultPage.PARAM_DOC_ID, UrlEncoder.QUERY_INSTANCE.encode(
                 docId,
                 Application.get().getRequestCycleSettings().getResponseRequestEncoding())); // get current character set from request cycle
-
+        // add the session persistent parameters
+        newParam.mergeWith(((VloSession) VloSession.get()).getVloSessionPageParameters());
         BookmarkablePageLink<ShowResultPage> docLink = new BookmarkablePageLink<ShowResultPage>(linkId, ShowResultPage.class,
                 newParam);