Changeset 4384

Timestamp:

01/29/14 13:22:07 (10 years ago)

Author:

twagoo

Message:

fixed potential null pointer exception in autocomplete dao

File:

• vlo/branches/vlo-2.18/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/dao/AutoCompleteDao.java (modified) (1 diff)

vlo/branches/vlo-2.18/vlo_web_app/src/main/java/eu/clarin/cmdi/vlo/dao/AutoCompleteDao.java

@@ -11 +11 @@
 /**
  * DAO that delivers suggestions for incomplete terms (autocomplete function)
- * 
+ *
  * @author Thomas Eckart
  *
  */
 public class AutoCompleteDao extends SolrDao {
-        
-        /**
-         * Returns list of suggestions for incomplete input (used for autocomplete function)
-         * @param input user input
-         * @return list of suggestions
-         */
-        public List<String> getChoices(String input) {
-                List<String> choices = new ArrayList<String>();
-                
-                SolrQuery query = new SolrQuery();
-                query.setQuery(input.toLowerCase());
-                query.setQueryType("/suggest");
-                QueryResponse response = fireQuery(query);
-                if(response.getSpellCheckResponse() != null) {
-                        List<Suggestion> suggestions = response.getSpellCheckResponse().getSuggestions();
-                        if(suggestions.size() > 0) {
-                                Iterator<String> iter = suggestions.get(0).getAlternatives().iterator();
-                                while(iter.hasNext()) {
-                                        choices.add(iter.next());
-                                }
-                        }
-                }
-                
-                return choices;
-        }
+
+    /**
+     * Returns list of suggestions for incomplete input (used for autocomplete
+     * function)
+     *
+     * @param input user input
+     * @return list of suggestions
+     */
+    public List<String> getChoices(String input) {
+        List<String> choices = new ArrayList<String>();
+
+        if (input != null) {
+            SolrQuery query = new SolrQuery();
+            query.setQuery(input.toLowerCase());
+            query.setQueryType("/suggest");
+            QueryResponse response = fireQuery(query);
+            if (response.getSpellCheckResponse() != null) {
+                List<Suggestion> suggestions = response.getSpellCheckResponse().getSuggestions();
+                if (suggestions.size() > 0) {
+                    Iterator<String> iter = suggestions.get(0).getAlternatives().iterator();
+                    while (iter.hasNext()) {
+                        choices.add(iter.next());
+                    }
+                }
+            }
+        }
+
+        return choices;
+    }
 }