Changeset 4652

Timestamp:

03/07/14 15:39:42 (10 years ago)

Author:

Twan Goosen

Message:

added processing of page parameter to record page (tests needed to be adapted)

Location:

vlo/branches/vlo-3.0/vlo-web-app/src

Files:

• main/java/eu/clarin/cmdi/vlo/wicket/pages/RecordPage.java (modified) (2 diffs)
• test/java/eu/clarin/cmdi/vlo/wicket/pages/TestFacetedSearchPage.java (modified) (2 diffs)
• test/java/eu/clarin/cmdi/vlo/wicket/pages/TestRecordPage.java (modified) (7 diffs)

vlo/branches/vlo-3.0/vlo-web-app/src/main/java/eu/clarin/cmdi/vlo/wicket/pages/RecordPage.java

@@ -52 +52 @@
 
     public RecordPage(PageParameters params) {
-        super(new SolrDocumentModel(params.get("docId").toString()));
+        super(params);
+        
+        final SolrDocumentModel documentModel = new SolrDocumentModel(params.get("docId").toString());
+        setModel(documentModel);
+        
         final QueryFacetsSelection selection = selectionParametersConverter.fromParameters(params);
         this.contextModel = Model.of(selection);
-        addComponents(getModel());
+        
+        addComponents(documentModel);
     }
 
@@ -65 +70 @@
 
     private void addComponents(IModel<SolrDocument> documentModel) {
-        if (documentModel.getObject() == null) {
-            throw new RuntimeException("Document not found in model " + documentModel.toString());
-        }
         add(new SolrFieldLabel("name", documentModel, FacetConstants.FIELD_NAME, "Unnamed record"));
         add(createLandingPageLink("landingPageLink", documentModel));

vlo/branches/vlo-3.0/vlo-web-app/src/test/java/eu/clarin/cmdi/vlo/wicket/pages/TestFacetedSearchPage.java

@@ -20 +20 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.test.annotation.DirtiesContext;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
@@ -28 +26 @@
 
 /**
- * Abstract base class for tests that require dependency injection of (mock)
- * objects and services. Based on blog post by Petri Kainulainen found at
+ * Mock injection based on blog post by Petri Kainulainen found at
  * {@link http://www.petrikainulainen.net/programming/tips-and-tricks/mocking-spring-beans-with-apache-wicket-and-mockito/}
- *
  */
 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(loader = AnnotationConfigContextLoader.class)
-//@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD) // gives us a fresh context for each test
 public class TestFacetedSearchPage {
 

vlo/branches/vlo-3.0/vlo-web-app/src/test/java/eu/clarin/cmdi/vlo/wicket/pages/TestRecordPage.java

@@ -6 +6 @@
 import eu.clarin.cmdi.vlo.config.VloConfigFactory;
 import eu.clarin.cmdi.vlo.config.VloSpringConfig;
-import eu.clarin.cmdi.vlo.pojo.QueryFacetsSelection;
+import eu.clarin.cmdi.vlo.service.SolrDocumentService;
 import org.apache.solr.common.SolrDocument;
-import org.apache.wicket.model.Model;
+import org.apache.wicket.request.mapper.parameter.PageParameters;
 import org.apache.wicket.util.tester.WicketTester;
+import org.jmock.Expectations;
+import static org.jmock.Expectations.returnValue;
+import org.jmock.Mockery;
+import org.jmock.integration.junit4.JUnit4Mockery;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.test.annotation.DirtiesContext;
@@ -21 +26 @@
 import org.springframework.test.context.support.AnnotationConfigContextLoader;
 
+/**
+ * Mock injection based on blog post by Petri Kainulainen found at
+ * {@link http://www.petrikainulainen.net/programming/tips-and-tricks/mocking-spring-beans-with-apache-wicket-and-mockito/}
+ */
 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(loader = AnnotationConfigContextLoader.class)
@@ -28 +37 @@
     @Configuration
     static class ContextConfiguration extends VloSpringConfig {
+
+        @Bean
+        public Mockery mockery() {
+            return new JUnit4Mockery();
+        }
+
+        @Override
+        public SolrDocumentService documentService() {
+            return mockery().mock(SolrDocumentService.class);
+        }
 
         @Override
@@ -40 +59 @@
     @Autowired(required = true)
     private VloWicketApplication application;
+    @Autowired(required = true)
+    private Mockery mockery;
+    @Autowired(required = true)
+    private SolrDocumentService documentService;
 
-    private QueryFacetsSelection selection;
     private SolrDocument document;
+    private PageParameters params;
 
     @Before
@@ -48 +71 @@
         tester = new WicketTester(application);
         document = new SolrDocument();
-        selection = new QueryFacetsSelection();
+        params = new PageParameters();
+        params.set("docId", "docId");
     }
 
     @Test
     public void testRendersSuccessfully() {
-        tester.startPage(new RecordPage(new Model(document), new Model(selection)));
+        mockery.checking(new Expectations() {
+            {
+                oneOf(documentService).getDocument("docId");
+                will(returnValue(document));
+            }
+        });
+        tester.startPage(RecordPage.class, params);
         //assert rendered page class
         tester.assertRenderedPage(RecordPage.class);
@@ -60 +90 @@
     @Test
     public void testLandingPageLinkInvisible() {
-        tester.startPage(new RecordPage(new Model(document), new Model(selection)));
+        mockery.checking(new Expectations() {
+            {
+                oneOf(documentService).getDocument("docId");
+                will(returnValue(document));
+            }
+        });
+        tester.startPage(RecordPage.class, params);
         // no landing page for document, assert landing page link is invisible
         tester.assertInvisible("landingPageLink");
@@ -68 +104 @@
     public void testLandingPageLinkVisible() {
         document.addField(FacetConstants.FIELD_LANDINGPAGE, "http://www.landingpage.com");
-        tester.startPage(new RecordPage(new Model(document), new Model(selection)));
+
+        mockery.checking(new Expectations() {
+            {
+                oneOf(documentService).getDocument("docId");
+                will(returnValue(document));
+            }
+        });
+        tester.startPage(RecordPage.class, params);
         // document has a landing page, assert link is invisible
         tester.assertVisible("landingPageLink");
     }
-    
+
     //TODO: Add test for display of resources
 }