Changeset 7190

Timestamp:

10/11/18 11:35:43 (6 years ago)

Author:

Oliver Schonefeld

Message:

• add convenience methods to SRUAbstractResponse: getDiagosticsCount() getExtraResponseDatacount()
• add convenience methods to SRUScanResponse: TermsCount?()
• add convenience methods to SRUSearchRetrieveResponse: getRecordsCount()
• fix NPE in SRUAbstractResponse::getExtraResponseData(Class)

Location:

SRUClient/trunk/src/main/java/eu/clarin/sru/client

Files:

• SRUAbstractResponse.java (modified) (5 diffs)
• SRUScanResponse.java (modified) (1 diff)
• SRUSearchRetrieveResponse.java (modified) (1 diff)

SRUClient/trunk/src/main/java/eu/clarin/sru/client/SRUAbstractResponse.java

@@ -125 +125 @@
 
     /**
+     * Get the number of diagnostics in the response.
+     * 
+     * <p>
+     * NB: Surrogate diagnostics are not covered by this.
+     * </p>
+     *
+     * @return the number of diagnostics or <code>0</code> is none
+     */
+    public int getDiagnosticsCount() {
+        return (diagnostics != null) ? diagnostics.size() : 0;
+    }
+
+
+    /**
      * Get the extra response data for this result.
      *
@@ -137 +151 @@
 
     /**
-     * Check, if this response has any extra response data attached to it.
+     * Check, if this response has any extra response data attached to the
+     * response.
      *
      * @return <code>true</code> if extra response is attached,
@@ -147 +162 @@
 
 
+    /**
+     * Return the number of extra response data records attached to the
+     * response.
+     * 
+     * @return the number of records, or <code>0</code> is none
+     */
+    public int getExtraResponseDataCount() {
+        return (extraResponseData != null) ? extraResponseData.size() : 0;
+    }
+    
+    
     /**
      * Get the extra response data of a specific class for this result.
@@ -155 +181 @@
      *            the type of {@link SRUExtraResponseData} to check for
      *
-     * @return a {@link SRUExtraResponseData} instances for the
+     * @return a list of {@link SRUExtraResponseData} instances for the
      *         extra response data from the SRU response or <code>null</code> if
      *         none are available
@@ -165 +191 @@
         }
         List<V> result = null;
-        for (SRUExtraResponseData i : extraResponseData) {
-            if (clazz.isInstance(i)) {
-                if (result == null) {
-                    result = new ArrayList<V>();
+        if (extraResponseData != null) {
+            for (SRUExtraResponseData i : extraResponseData) {
+                if (clazz.isInstance(i)) {
+                    if (result == null) {
+                        result = new ArrayList<V>();
+                    }
+                    result.add(clazz.cast(i));
                 }
-                result.add(clazz.cast(i));
             }
         }

SRUClient/trunk/src/main/java/eu/clarin/sru/client/SRUScanResponse.java

@@ -67 +67 @@
     }
 
+
+    /**
+     * Get the number of terms returned by the request.
+     * 
+     * @return the number of terms or <code>0</code> if none
+     */
+    public int getTermsCount() {
+        return (terms != null) ? terms.size() : 0;
+    }
+
 } // class SRUScanResponse

SRUClient/trunk/src/main/java/eu/clarin/sru/client/SRUSearchRetrieveResponse.java

@@ -111 +111 @@
 
     /**
+     * Get the number of records returned by the request.
+     * 
+     * @return number of records or <code>0</code> if none
+     */
+    public int getRecordsCount() {
+        return (records != null) ? records.size() : 0;
+    }
+
+
+    /**
      * Get the next record position.
      *