Changeset 1895 for ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/impl/database/ComponentRegistryDbImpl.java

Timestamp:

04/20/12 12:59:56 (12 years ago)

Author:

twagoo

Message:

CommentsDao?.getById takes Id as Number. Added test for this method

File:

• ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/impl/database/ComponentRegistryDbImpl.java (modified) (2 diffs)

ComponentRegistry/trunk/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/impl/database/ComponentRegistryDbImpl.java

@@ -653 +653 @@
             ComponentRegistryException, UserUnauthorizedException, DeleteFailedException {
         try {
-            Comment comment = commentsDao.getById(commentId);
+            Comment comment = commentsDao.getById(Integer.parseInt(commentId));
             if (comment != null
                     // Comment must have an existing (in this registry) componentId or profileId
@@ -666 +666 @@
         } catch (DataAccessException ex) {
             throw new DeleteFailedException("Database access error while trying to delete component", ex);
+        } catch (NumberFormatException ex) {
+            throw new DeleteFailedException("Illegal comment ID, cannot parse integer", ex);
         }
     }