Ignore:
Timestamp:
08/14/13 16:34:29 (11 years ago)
Author:
olhsha
Message:

"put updated body" is implemented and tested. Big refactring: simplifying DAO's and pushing their composition to rest methods. add-methods in DAO return now not the classes but internalID-s of the added resources. Still 2 test errors and 2 test failures.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcVersionDao.java

    r3372 r3380  
    5151        return new VersionIdentifier(super.getExternalIdentifier(internalID));
    5252    }
     53   
     54      //////////////////////////////////////////////////////////////////////////////////////////////////////   
     55    @Override
     56    public Number getInternalID(VersionIdentifier externalID) {
     57        return (super.getInternalID(externalID));
     58    }
     59   
    5360    ///////////////////////////////////////////////////////////////
    5461
     
    158165    /////////////////////////////////////////////////
    159166    @Override
    160     public Version addVersion(Version freshVersion) {
     167    public Number addVersion(Version freshVersion) {
    161168        VersionIdentifier externalIdentifier = new VersionIdentifier();
    162169        String newExternalIdentifier = externalIdentifier.toString();
     
    168175        String sql = "INSERT INTO " + versionTableName + "(" + external_id + "," + version + " ) VALUES (:externalId, :version)";
    169176        final int affectedRows = getSimpleJdbcTemplate().update(sql, params);
    170 
    171         if (affectedRows == 1) {
    172             Version versionAdded = makeFreshCopy(freshVersion);
    173             // TODO change for external identifier when the schema is fixed
    174             versionAdded.setVersion(newExternalIdentifier);
    175             return versionAdded;
    176         } else {
    177             return null;
    178         }
    179 
    180         // adding the corresponding cached representation is initiated from the separate service POST api/sources/<sid>/cached
    181         // so it is not implemented here
     177        return getInternalID(externalIdentifier);
    182178    }
    183179
     
    213209    }
    214210
    215     ////////////////////// HELPERS ///////////////////////////////
    216     private Version makeFreshCopy(Version version) {
    217         Version result = new Version();
    218         // TOD: add external ID when the schema is corrected
    219         result.setVersion(version.getVersion());
    220         return result;
    221     }
     211   
    222212}
Note: See TracChangeset for help on using the changeset viewer.