Changeset 3464


Ignore:
Timestamp:
08/23/13 16:23:28 (11 years ago)
Author:
olhsha
Message:

replacing String with StringBuilder? for the SQL request-strings

Location:
DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcCachedRepresentationDao.java

    r3463 r3464  
    4949    public CachedRepresentationInfo getCachedRepresentationInfo(Number internalID) {
    5050
    51         String sql = "SELECT " + cachedRepresentationStar + " FROM " + cachedRepresentationTableName + " WHERE " + cached_representation_id + "= ? LIMIT 1";
    52         List<CachedRepresentationInfo> result = getSimpleJdbcTemplate().query(sql, cachedRepresentationRowMapper, internalID);
     51        StringBuilder sql = new StringBuilder("SELECT ");
     52        sql.append(cachedRepresentationStar).append(" FROM ").append(cachedRepresentationTableName).append(" WHERE ").append(cached_representation_id).append("= ? LIMIT 1");
     53        List<CachedRepresentationInfo> result = getSimpleJdbcTemplate().query(sql.toString(), cachedRepresentationRowMapper, internalID);
    5354
    5455        if (result.isEmpty()) {
    … …  
    7374
    7475    private boolean cachedIsInUse(Number cachedID) {     
    75         String sql = "SELECT " + version_id + " FROM " + versionsCachedRepresentationsTableName + " WHERE " + cached_representation_id + "= ? LIMIT 1";
    76         List<Number> result = getSimpleJdbcTemplate().query(sql, versionIDRowMapper, cachedID);
     76        StringBuilder sql = new StringBuilder("SELECT ");
     77        sql.append(version_id).append(" FROM ").append(versionsCachedRepresentationsTableName).append(" WHERE ").append(cached_representation_id).append("= ? LIMIT 1");
     78        List<Number> result = getSimpleJdbcTemplate().query(sql.toString(), versionIDRowMapper, cachedID);
    7779        return (!result.isEmpty());
    7880    }
    … …  
    8991        params.put("tool", cached.getTool());
    9092        params.put("type", cached.getType());
    91         String sql = "INSERT INTO " + cachedRepresentationTableName + "(" + external_id + "," + mime_type + "," + tool + "," + type_ + " ) VALUES (:externalId, :mime_type,  :tool, :type)";
    92         final int affectedRows = getSimpleJdbcTemplate().update(sql, params);
     93        StringBuilder sql = new StringBuilder("INSERT INTO ");
     94        sql.append(cachedRepresentationTableName).append("(").append(external_id).append(",").append(mime_type).append(",").append(tool).append("," ).append(type_).append(" ) VALUES (:externalId, :mime_type,  :tool, :type)");
     95        final int affectedRows = getSimpleJdbcTemplate().update(sql.toString(), params);
    9396        return (affectedRows > 0 ? getInternalID(externalIdentifier) : null);
    9497    }
    … …  
    101104        }
    102105       
    103         String sql = "DELETE FROM " + cachedRepresentationTableName + " where " + cached_representation_id + " = ?";
    104         return  getSimpleJdbcTemplate().update(sql, internalID);
     106        StringBuilder sql = new StringBuilder("DELETE FROM ");
     107        sql.append(cachedRepresentationTableName).append(" WHERE ").append(cached_representation_id).append(" = ?");
     108        return  getSimpleJdbcTemplate().update(sql.toString(), internalID);
    105109    }
    106110   

  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcResourceDao.java

    r3463 r3464  
    105105            return null;
    106106        }
    107         String sql = "SELECT " + internalIdName + " FROM " + resourceTableName + " WHERE " + external_id + "= ? LIMIT 1";
    108         List<Number> sqlResult = getSimpleJdbcTemplate().query(sql, internalIDRowMapper, externalId.toString());
    109 
    110         if (sqlResult.isEmpty()) {
    111             return null;
    112         }
    113 
    114         Number result = sqlResult.get(0);
    115         return result;
     107        StringBuilder sql = new StringBuilder("SELECT ");
     108        sql.append(internalIdName).append(" FROM ").append(resourceTableName).append(" WHERE ").append(external_id).append("= ? LIMIT 1");
     109        List<Number> sqlResult = getSimpleJdbcTemplate().query(sql.toString(), internalIDRowMapper, externalId.toString());
     110        return (sqlResult.isEmpty() ? null: sqlResult.get(0));
    116111    }
    117112
    118113    @Override
    119114    public UUID getExternalID(Number internalId) {
    120         String sql = "SELECT " + external_id + " FROM " + resourceTableName + " WHERE " + internalIdName + "= ? LIMIT 1";
    121         List<UUID> sqlResult = getSimpleJdbcTemplate().query(sql, externalIDRowMapper, internalId);
    122         if (sqlResult.isEmpty()) {
    123             return null;
    124         }
    125 
    126         return (sqlResult.get(0));
     115        StringBuilder sql = new StringBuilder("SELECT ");
     116        sql.append(external_id).append(" FROM ").append(resourceTableName).append(" WHERE ").append(internalIdName).append("= ? LIMIT 1");
     117        List<UUID> sqlResult = getSimpleJdbcTemplate().query(sql.toString(), externalIDRowMapper, internalId);
     118        return (sqlResult.isEmpty() ? null : sqlResult.get(0));
    127119    }
    128120
    129121    /////////////////////////////////////////////////////
    130122    protected XMLGregorianCalendar retrieveTimeStamp(Number internalID) {
    131         String sqlTime = "SELECT " + time_stamp + " FROM " + resourceTableName + " WHERE " + internalIdName + "= ? LIMIT 1";
    132         List<XMLGregorianCalendar> timeStamp = getSimpleJdbcTemplate().query(sqlTime, timeStampRowMapper, internalID);
     123        StringBuilder sqlTime = new  StringBuilder("SELECT ");
     124        sqlTime.append(time_stamp).append(" FROM ").append(resourceTableName).append(" WHERE ").append(internalIdName).append("= ? LIMIT 1");
     125        List<XMLGregorianCalendar> timeStamp = getSimpleJdbcTemplate().query(sqlTime.toString(), timeStampRowMapper, internalID);
    133126        if (timeStamp.isEmpty()) {
    134127            return null;

  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcSourceDao.java

    r3463 r3464  
    5151    @Override
    5252    public Source getSource(Number internalID) {
    53         String sql = "SELECT " + sourceStar + "FROM " + sourceTableName + " WHERE " + source_id + " = ?";
    54         List<Source> result = getSimpleJdbcTemplate().query(sql, sourceRowMapper, internalID);
     53        StringBuilder sql = new StringBuilder("SELECT ");
     54        sql.append(sourceStar).append(" FROM ").append(sourceTableName).append(" WHERE ").append(source_id).append("= ? LIMIT 1");
     55        List<Source> result = getSimpleJdbcTemplate().query(sql.toString(), sourceRowMapper, internalID);
    5556        return (!result.isEmpty() ? result.get(0) : null);
    5657    }
    … …  
    7475    @Override
    7576    public List<Number> retrieveVersionList(Number sourceID) {
     77       
    7678        String sql = "SELECT " + version_id + " FROM " + sourcesVersionsTableName + " WHERE " + source_id + " = ?";
    7779        return getSimpleJdbcTemplate().query(sql, versionIDRowMapper, sourceID);
    … …  
    9092
    9193        String sourceIDs = makeListOfValues(sources);
    92         String sql = "SELECT " + external_id + "," + link_uri + "," + version + " FROM " + sourceTableName + " WHERE " + source_id + " IN " + sourceIDs;
    93         return getSimpleJdbcTemplate().query(sql, SourceInfoRowMapper);
     94       
     95        StringBuilder sql = new StringBuilder("SELECT ");
     96        sql.append(external_id).append(",").append(link_uri).append(",").append(version).
     97                append(" FROM ").append(sourceTableName).append(" WHERE ").append(source_id).append(" IN ").append(sourceIDs);
     98        return getSimpleJdbcTemplate().query(sql.toString(), SourceInfoRowMapper);
    9499    }
    95100    private final RowMapper<SourceInfo> SourceInfoRowMapper = new RowMapper<SourceInfo>() {
    … …  
    113118    @Override
    114119    public boolean sourceIsInUse(Number sourceID) {
    115         String sqlAnnotations = "SELECT " + annotation_id + " FROM " + annotationsSourcesTableName + " WHERE " + source_id + "= ? LIMIT 1";
    116         List<Number> resultAnnotations = getSimpleJdbcTemplate().query(sqlAnnotations, annotationIDRowMapper, sourceID);
     120        StringBuilder sqlAnnotations = new StringBuilder("SELECT ");
     121        sqlAnnotations.append(annotation_id).append(" FROM ").append(annotationsSourcesTableName).append(" WHERE ").append(source_id).append(" = ? LIMIT 1");
     122        List<Number> resultAnnotations = getSimpleJdbcTemplate().query(sqlAnnotations.toString(), annotationIDRowMapper, sourceID);
    117123        if (resultAnnotations.size() > 0) {
    118124            return true;
    119         }
    120         String sqlVersions = "SELECT " + version_id + " FROM " + sourcesVersionsTableName + " WHERE " + source_id + "= ? LIMIT 1";
    121         List<Number> resultVersions = getSimpleJdbcTemplate().query(sqlVersions, versionIDRowMapper, sourceID);
     125        }       
     126        StringBuilder sqlVersions = new StringBuilder("SELECT ");
     127        sqlVersions.append(version_id).append(" FROM ").append(sourcesVersionsTableName).append(" WHERE ").append(source_id).append(" = ? LIMIT 1");
     128        List<Number> resultVersions = getSimpleJdbcTemplate().query(sqlVersions.toString(), versionIDRowMapper, sourceID);
    122129        return (resultVersions.size() > 0);
    123130    }
    … …  
    134141        params.put("linkUri", source.getLink());
    135142        params.put("version", source.getVersion());
    136         String sql = "INSERT INTO " + sourceTableName + "(" + external_id + "," + link_uri + "," + version + " ) VALUES (:externalId, :linkUri,  :version)";
    137         final int affectedRows = getSimpleJdbcTemplate().update(sql, params); 
     143        StringBuilder sql = new StringBuilder("INSERT INTO ");
     144        sql.append(sourceTableName).append("(").append(external_id).append(",").append(link_uri).append(",").append(version).append(" ) VALUES (:externalId, :linkUri,  :version)");
     145        final int affectedRows = getSimpleJdbcTemplate().update(sql.toString(), params); 
    138146        return (affectedRows>0 ? getInternalID(UUID.fromString(externalID.toString())) : null);
    139147    }
    … …  
    146154        paramsJoint.put("sourceId", sourceID);
    147155        paramsJoint.put("versionId", versionID);
    148         String sqlJoint = "INSERT INTO " + sourcesVersionsTableName + "(" + source_id + "," + version_id + " ) VALUES (:sourceId, :versionId)";
    149         return getSimpleJdbcTemplate().update(sqlJoint, paramsJoint);
     156        StringBuilder sqlJoint = new StringBuilder("INSERT INTO ").append(sourcesVersionsTableName).append("(").append(source_id).append(",").append(version_id).append(" ) VALUES (:sourceId, :versionId)");
     157        return getSimpleJdbcTemplate().update(sqlJoint.toString(), paramsJoint);
    150158    }
    151159   
    … …  
    156164            return 0;
    157165        }
    158         String sqlSourcesVersions = "DELETE FROM " + sourceTableName + " WHERE " + source_id + " = ? ";
    159         return getSimpleJdbcTemplate().update(sqlSourcesVersions, internalID);
     166        StringBuilder sqlSourcesVersions = new StringBuilder("DELETE FROM ");
     167        sqlSourcesVersions.append(sourceTableName).append(" WHERE ").append(source_id).append(" = ? ");
     168        return getSimpleJdbcTemplate().update(sqlSourcesVersions.toString(), internalID);
    160169
    161170    }
    … …  
    165174    @Override
    166175    public int deleteAllSourceVersion(Number internalID) {
    167         String sqlSourcesVersions = "DELETE FROM " + sourcesVersionsTableName + " WHERE " + source_id + " = ?";
    168         return getSimpleJdbcTemplate().update(sqlSourcesVersions, internalID);
     176        StringBuilder sqlSourcesVersions = new StringBuilder("DELETE FROM ");
     177        sqlSourcesVersions.append(sourcesVersionsTableName).append(" WHERE ").append(source_id).append(" = ?");
     178        return getSimpleJdbcTemplate().update(sqlSourcesVersions.toString(), internalID);
    169179
    170180    }

  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcVersionDao.java

    r3463 r3464  
    4747    public Version getVersion(Number internalID) {
    4848
    49         String sql = "SELECT " + versionStar + " FROM " + versionTableName + " WHERE " + version_id + "= ? LIMIT 1";
    50         List<Version> result = getSimpleJdbcTemplate().query(sql, versionRowMapper, internalID);
     49        StringBuilder sql  = new StringBuilder("SELECT ");
     50        sql.append(versionStar).append(" FROM ").append(versionTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     51        List<Version> result = getSimpleJdbcTemplate().query(sql.toString(), versionRowMapper, internalID);
    5152        return (!result.isEmpty() ? result.get(0) : null);
    5253    }
    … …  
    6667    @Override
    6768    public List<Number> retrieveCachedRepresentationList(Number versionID) {
    68         String sql = "SELECT DISTINCT " + cached_representation_id + " FROM " + versionsCachedRepresentationsTableName + " WHERE " + version_id + "= ?";
    69         return getSimpleJdbcTemplate().query(sql, cachedIDRowMapper, versionID);
     69        StringBuilder sql  = new StringBuilder("SELECT DISTINCT ");
     70        sql.append(cached_representation_id).append(" FROM ").append(versionsCachedRepresentationsTableName).append(" WHERE ").append(version_id).append("= ?");
     71        return getSimpleJdbcTemplate().query(sql.toString(), cachedIDRowMapper, versionID);
    7072    }
    7173
    … …  
    7678    @Override
    7779    public boolean versionIsInUse(Number versionsID) {
    78         String sqlSources = "SELECT " + source_id + " FROM " + sourcesVersionsTableName + " WHERE " + version_id + "= ? LIMIT 1";
    79         List<Number> resultSources = getSimpleJdbcTemplate().query(sqlSources, sourceIDRowMapper, versionsID);
     80        StringBuilder sqlSources  = new StringBuilder("SELECT ");
     81        sqlSources.append(source_id).append(" FROM ").append(sourcesVersionsTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     82        List<Number> resultSources = getSimpleJdbcTemplate().query(sqlSources.toString(), sourceIDRowMapper, versionsID);
    8083        if (resultSources.size() > 0) {
    8184            return true;
    8285        }
    83         String sqlVersions = "SELECT " + cached_representation_id + " FROM " + versionsCachedRepresentationsTableName + " WHERE " + version_id + "= ? LIMIT 1";
    84         List<Number> resultCached = getSimpleJdbcTemplate().query(sqlVersions, cachedIDRowMapper, versionsID);
     86        StringBuilder sqlCached  = new StringBuilder("SELECT ");
     87        sqlCached.append(cached_representation_id).append(" FROM ").append(versionsCachedRepresentationsTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     88        List<Number> resultCached = getSimpleJdbcTemplate().query(sqlCached.toString(), cachedIDRowMapper, versionsID);
    8589        return (resultCached.size() > 0) ;
    8690    }
    … …  
    99103        //TODO: till the schema is fixed, version-text and version's external Id are the same (now version do not have URI's/ext id's)
    100104        params.put("version", newExternalIdentifier);
    101         String sql = "INSERT INTO " + versionTableName + "(" + external_id + "," + version + " ) VALUES (:externalId, :version)";
    102         final int affectedRows = getSimpleJdbcTemplate().update(sql, params);
     105        StringBuilder sql = new StringBuilder("INSERT INTO ");
     106        sql.append(versionTableName).append("(").append(external_id).append(",").append(version).append(" ) VALUES (:externalId, :version)");
     107        final int affectedRows = getSimpleJdbcTemplate().update(sql.toString(), params);
    103108        return (affectedRows>0 ? getInternalID(externalIdentifier) : null);
    104109    }
    … …  
    110115        params.put("versionId", versionID);
    111116        params.put("cachedId", cachedID);
    112         String sql = "INSERT INTO " + versionsCachedRepresentationsTableName + "(" + version_id + "," + cached_representation_id + " ) VALUES (:versionId, :cachedId)";
    113         return getSimpleJdbcTemplate().update(sql, params);
     117        StringBuilder sql = new StringBuilder("INSERT INTO ");
     118        sql.append(versionsCachedRepresentationsTableName).append("(").append(version_id).append(",").append(cached_representation_id).append(" ) VALUES (:versionId, :cachedId)");
     119        return getSimpleJdbcTemplate().update(sql.toString(), params);
    114120    }
    115121   
    … …  
    122128            return 0;
    123129        }       
    124         String sql = "DELETE FROM " + versionTableName + " where " + version_id + " = ?";
    125         return getSimpleJdbcTemplate().update(sql, internalID);
     130        StringBuilder sql = new StringBuilder("DELETE FROM ");
     131        sql.append(versionTableName).append(" where ").append(version_id).append(" = ?");
     132        return getSimpleJdbcTemplate().update(sql.toString(), internalID);
    126133
    127134    }
Note: See TracChangeset for help on using the changeset viewer.