Ignore:
Timestamp:
08/23/13 16:23:28 (11 years ago)
Author:
olhsha
Message:

replacing String with StringBuilder? for the SQL request-strings

File:
1 edited

Legend:

Unmodified
Added
Removed

  • DASISH/t5.6/backend/annotator-backend/trunk/annotator-backend/src/main/java/eu/dasish/annotation/backend/dao/impl/JdbcVersionDao.java

    r3463 r3464  
    4747    public Version getVersion(Number internalID) {
    4848
    49         String sql = "SELECT " + versionStar + " FROM " + versionTableName + " WHERE " + version_id + "= ? LIMIT 1";
    50         List<Version> result = getSimpleJdbcTemplate().query(sql, versionRowMapper, internalID);
     49        StringBuilder sql  = new StringBuilder("SELECT ");
     50        sql.append(versionStar).append(" FROM ").append(versionTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     51        List<Version> result = getSimpleJdbcTemplate().query(sql.toString(), versionRowMapper, internalID);
    5152        return (!result.isEmpty() ? result.get(0) : null);
    5253    }
    … …  
    6667    @Override
    6768    public List<Number> retrieveCachedRepresentationList(Number versionID) {
    68         String sql = "SELECT DISTINCT " + cached_representation_id + " FROM " + versionsCachedRepresentationsTableName + " WHERE " + version_id + "= ?";
    69         return getSimpleJdbcTemplate().query(sql, cachedIDRowMapper, versionID);
     69        StringBuilder sql  = new StringBuilder("SELECT DISTINCT ");
     70        sql.append(cached_representation_id).append(" FROM ").append(versionsCachedRepresentationsTableName).append(" WHERE ").append(version_id).append("= ?");
     71        return getSimpleJdbcTemplate().query(sql.toString(), cachedIDRowMapper, versionID);
    7072    }
    7173
    … …  
    7678    @Override
    7779    public boolean versionIsInUse(Number versionsID) {
    78         String sqlSources = "SELECT " + source_id + " FROM " + sourcesVersionsTableName + " WHERE " + version_id + "= ? LIMIT 1";
    79         List<Number> resultSources = getSimpleJdbcTemplate().query(sqlSources, sourceIDRowMapper, versionsID);
     80        StringBuilder sqlSources  = new StringBuilder("SELECT ");
     81        sqlSources.append(source_id).append(" FROM ").append(sourcesVersionsTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     82        List<Number> resultSources = getSimpleJdbcTemplate().query(sqlSources.toString(), sourceIDRowMapper, versionsID);
    8083        if (resultSources.size() > 0) {
    8184            return true;
    8285        }
    83         String sqlVersions = "SELECT " + cached_representation_id + " FROM " + versionsCachedRepresentationsTableName + " WHERE " + version_id + "= ? LIMIT 1";
    84         List<Number> resultCached = getSimpleJdbcTemplate().query(sqlVersions, cachedIDRowMapper, versionsID);
     86        StringBuilder sqlCached  = new StringBuilder("SELECT ");
     87        sqlCached.append(cached_representation_id).append(" FROM ").append(versionsCachedRepresentationsTableName).append(" WHERE ").append(version_id).append("= ? LIMIT 1");
     88        List<Number> resultCached = getSimpleJdbcTemplate().query(sqlCached.toString(), cachedIDRowMapper, versionsID);
    8589        return (resultCached.size() > 0) ;
    8690    }
    … …  
    99103        //TODO: till the schema is fixed, version-text and version's external Id are the same (now version do not have URI's/ext id's)
    100104        params.put("version", newExternalIdentifier);
    101         String sql = "INSERT INTO " + versionTableName + "(" + external_id + "," + version + " ) VALUES (:externalId, :version)";
    102         final int affectedRows = getSimpleJdbcTemplate().update(sql, params);
     105        StringBuilder sql = new StringBuilder("INSERT INTO ");
     106        sql.append(versionTableName).append("(").append(external_id).append(",").append(version).append(" ) VALUES (:externalId, :version)");
     107        final int affectedRows = getSimpleJdbcTemplate().update(sql.toString(), params);
    103108        return (affectedRows>0 ? getInternalID(externalIdentifier) : null);
    104109    }
    … …  
    110115        params.put("versionId", versionID);
    111116        params.put("cachedId", cachedID);
    112         String sql = "INSERT INTO " + versionsCachedRepresentationsTableName + "(" + version_id + "," + cached_representation_id + " ) VALUES (:versionId, :cachedId)";
    113         return getSimpleJdbcTemplate().update(sql, params);
     117        StringBuilder sql = new StringBuilder("INSERT INTO ");
     118        sql.append(versionsCachedRepresentationsTableName).append("(").append(version_id).append(",").append(cached_representation_id).append(" ) VALUES (:versionId, :cachedId)");
     119        return getSimpleJdbcTemplate().update(sql.toString(), params);
    114120    }
    115121   
    … …  
    122128            return 0;
    123129        }       
    124         String sql = "DELETE FROM " + versionTableName + " where " + version_id + " = ?";
    125         return getSimpleJdbcTemplate().update(sql, internalID);
     130        StringBuilder sql = new StringBuilder("DELETE FROM ");
     131        sql.append(versionTableName).append(" where ").append(version_id).append(" = ?");
     132        return getSimpleJdbcTemplate().update(sql.toString(), internalID);
    126133
    127134    }
Note: See TracChangeset for help on using the changeset viewer.