Changeset 6022 for vlo/trunk/vlo-web-app/src/test/java/eu/clarin/cmdi/vlo/service/impl/QueryFacetsSelectionParametersConverterTest.java

Timestamp:

02/23/15 15:57:05 (9 years ago)

Author:

Twan Goosen

Message:

Parameters converter that maps to query facet selection now checks whether facets passed in as parameters do actually exist according to the configuration. If not, logs a debug message and notifies the user via a wicket error message

File:

• vlo/trunk/vlo-web-app/src/test/java/eu/clarin/cmdi/vlo/service/impl/QueryFacetsSelectionParametersConverterTest.java (modified) (3 diffs)

vlo/trunk/vlo-web-app/src/test/java/eu/clarin/cmdi/vlo/service/impl/QueryFacetsSelectionParametersConverterTest.java

@@ -17 +17 @@
 package eu.clarin.cmdi.vlo.service.impl;
 
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Maps;
+import static eu.clarin.cmdi.vlo.FacetConstants.FIELD_COLLECTION;
+import static eu.clarin.cmdi.vlo.FacetConstants.FIELD_COUNTRY;
+import eu.clarin.cmdi.vlo.config.VloConfig;
 import eu.clarin.cmdi.vlo.pojo.FacetSelection;
 import eu.clarin.cmdi.vlo.pojo.FacetSelectionType;
@@ -44 +48 @@
     @Before
     public void setUp() {
-        instance = new QueryFacetsSelectionParametersConverter();
+        VloConfig config = new VloConfig() {
+
+            @Override
+            public List<String> getAllFacetFields() {
+                return ImmutableList.of("facet1", "facet2", "facet3", "facet4");
+            }
+
+        };
+        instance = new QueryFacetsSelectionParametersConverter(config);
     }
 
@@ -60 +72 @@
         params.add("fq", "facet2:value:C"); // has a colon in value
         params.add("fq", "illegal-no-colon"); //should get ignored
+        params.add("fq", "facet5:valueD"); //not in list, should get ignored
         params.add("fq", ""); // not a valid facet selection
         params.add("fq", "invalid"); // not a valid facet selection