Opened 6 years ago

Closed 5 years ago

#1074 closed defect (fixed)

Search results page does not allow collapsing the "advanced search" options while logged in

Reported by: André Moreira Owned by: André Moreira
Priority: major Milestone:
Component: Website Version:
Keywords: Cc:

Description (last modified by André Moreira)

When logged in the www.clarin.eu website, the search results page initially renders the area of the fully expanded "advanced search" pane, but without rendering the content of this pane (whole area is empty).

This pane should initially render as collapsed.

Moreover, when the pane is manually collapsed, one cannot click the search result links (tested on Firefox). They are somewhere down the page in random areas (as if the pane was being displayed expanded). This should also not happen.

The problem only exists when the user performs a search while logged in.

Change History (8)

comment:1 Changed 6 years ago by André Moreira

Owner: changed from André Moreira to mail@hendrikschmeer.de
Status: newassigned

comment:2 Changed 6 years ago by André Moreira

Description: modified (diff)

comment:3 Changed 5 years ago by mail@hendrikschmeer.de

The problem originates from line 266 in this file:
https://github.com/clarin-eric/clarin-horizon_drupal_theme/blob/master/src/less/overrides.less,
committed on July, 9th 2018.
fieldset .panel-body { display: inherit; } is overriding the proper style from Bootstrap (display: none).

Proposed solution: create a branch without line 266 and test possible side effects for a while on dev.

comment:4 Changed 5 years ago by mail@hendrikschmeer.de

Resolution: fixed
Status: assignedclosed

comment:5 Changed 5 years ago by André Moreira

Resolution: fixed
Status: closedreopened

Fix deployed on https://dev-www.clarin.eu . Let's stage it there for a day or two. Reopening and reassigning to myself.

Fix PR: https://github.com/clarin-eric/clarin-horizon_drupal_theme/pull/5

comment:6 Changed 5 years ago by André Moreira

Owner: changed from mail@hendrikschmeer.de to André Moreira
Status: reopenedassigned

comment:7 Changed 5 years ago by Dieter Van Uytvanck

Seems to work well. Can we progagate the fix to production?

comment:8 Changed 5 years ago by André Moreira

Resolution: fixed
Status: assignedclosed

Done!

Note: See TracTickets for help on using tickets.