code duplication on clients site

[olhsha]

there are a few code blocks in client-site (flex) that are met in two or more copies in different places. It should be refactored.

[olhsha]

fixed but need more testing on the developer's machine

[olhsha]

There are different action-script classes that contain methods with "almost the same code".

In particular, this is the case for the classes that perform work over/for Components and the classes that perform work over/for Profiles. Compare, for instance, ComponentInfoService?.as and ProfileInfoService?.as, or ComponentListService?.as and ProfileListService?.as.

Accurate code parsing will give you other examples.

The aim is to get rid (when reasonable) from code repetition, e.g. by using inheritance.

[olhsha]

Also check the following pairs in ComponentEdit?.as, if they can be refactored:

private function addComponentAddButton():void
private function addElementAddButton():void

addComponent(component:CMDComponent)
addElement(element:CMDComponentElement)

private function removeComponent(event:Event)
private function removeElement(event:Event)

[g.georgovassilis@mpi.nl]

Introduced BaseRemoteService? to handle http/xml communication with the backend. Provides URL management, error handling, extracting XML. Also introduced HttpServiceFactory? and to allow for mocking http communication in unit tests (see ComponentInfoServiceTest? for an example).

[olhsha]

Also, to check for refactoring:

---

CMDComponentElementBrowser.as and ComponentBrowse?.as

handleElements(elements:ArrayCollection)
handleComponents(components:ArrayCollection)

---

ComponentBrowse?.as and ElementBrowse?.as.:
addLine, addChild

---

BrowserColumn?.as

public function getProfileColumns()
public function getComponentColumns()

getInitialSortForProfiles()
getInitialSortForComponents()

---------------------------------

CMDcomponent.as:

removeComponent vs removeElement
moveDownElement vs moveDownElement
moveUpComponent vs moveUpElement