Opened 10 years ago

Closed 9 years ago

#668 closed enhancement (fixed)

Fall back to patterns if there are no concept link matches

Reported by: Twan Goosen Owned by: Menzo Windhouwer
Priority: major Milestone: VLO-3.1
Component: VLO importer Version:
Keywords: Cc: Twan Goosen

Description

The VLO importer never falls back to patterns if a profile has concept links for a given facet, even if there are no matches based on concept links. This should be an option. There is a potential for unexpected side effects, so this needs to be checked after implementation.

See #554 for a use case.

Change History (4)

comment:1 Changed 10 years ago by DefaultCC Plugin

Cc: Twan Goosen added

comment:2 Changed 10 years ago by herold@bbaw.de

I don't understand which patterns are meant here. I'd expect the following behaviour:

Look for a metadata element that matches the facet description. If found: use the value (can be empty, though, i.e. "unspecified"). If not found: generate an "unknown" value.

comment:3 in reply to:  2 Changed 10 years ago by Twan Goosen

Replying to herold@…:

I don't understand which patterns are meant here. I'd expect the following behaviour:

Look for a metadata element that matches the facet description. If found: use the value (can be empty, though, i.e. "unspecified"). If not found: generate an "unknown" value.

Patterns mean XPaths here. This ticket is about the places in the document that are even considered for looking for a value for a specific facet. The current behaviour is: if a profile has a matching data category, completely ignore any XPath that might match. So even if an instance of such a profile (a CMDI document) has no value in one of the fields matching the data category, the XPaths do not get checked either. To change its behaviour to fall back in such cases is what is proposed in this ticket.

comment:4 Changed 9 years ago by teckart@informatik.uni-leipzig.de

Milestone: VLO-3.1
Resolution: fixed
Status: newclosed

Commited to trunk (r5985) - at least no evident problems with this new approach

Note: See TracTickets for help on using tickets.